Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
senpy
senpy
Commits
23c88d0a
Commit
23c88d0a
authored
Jan 18, 2018
by
J. Fernando Sánchez
Browse files
Improve error handling
parent
dcaaa591
Changes
2
Hide whitespace changes
Inline
Side-by-side
senpy/extensions.py
View file @
23c88d0a
...
...
@@ -16,7 +16,6 @@ import os
import
copy
import
errno
import
logging
import
traceback
logger
=
logging
.
getLogger
(
__name__
)
...
...
@@ -171,22 +170,14 @@ class Senpy(object):
by api.parse_call().
"""
logger
.
debug
(
"analysing request: {}"
.
format
(
request
))
try
:
entries
=
request
.
entries
request
.
entries
=
[]
plugins
=
self
.
_get_plugins
(
request
)
results
=
request
for
i
in
self
.
_process_entries
(
entries
,
results
,
plugins
):
results
.
entries
.
append
(
i
)
self
.
convert_emotions
(
results
)
logger
.
debug
(
"Returning analysis result: {}"
.
format
(
results
))
except
(
Error
,
Exception
)
as
ex
:
if
not
isinstance
(
ex
,
Error
):
msg
=
"Error during analysis: {}
\n\t
{}"
.
format
(
ex
,
traceback
.
format_exc
())
ex
=
Error
(
message
=
msg
,
status
=
500
)
logger
.
exception
(
'Error returning analysis result'
)
raise
ex
entries
=
request
.
entries
request
.
entries
=
[]
plugins
=
self
.
_get_plugins
(
request
)
results
=
request
for
i
in
self
.
_process_entries
(
entries
,
results
,
plugins
):
results
.
entries
.
append
(
i
)
self
.
convert_emotions
(
results
)
logger
.
debug
(
"Returning analysis result: {}"
.
format
(
results
))
results
.
analysis
=
[
i
[
'plugin'
].
id
for
i
in
results
.
analysis
]
return
results
...
...
tests/test_extensions.py
View file @
23c88d0a
...
...
@@ -182,8 +182,7 @@ class ExtensionsTest(TestCase):
analyse
(
self
.
senpy
,
input
=
'nothing'
,
algorithm
=
'MOCK'
)
assert
False
except
Exception
as
ex
:
assert
'generic exception on analysis'
in
ex
[
'message'
]
assert
ex
[
'status'
]
==
500
assert
'generic exception on analysis'
in
str
(
ex
)
def
test_filtering
(
self
):
""" Filtering plugins """
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment